Filecache sdk upgrade #756
Conversation
k8s-ci-robot
added
cncf-cla: yes
micahhausler
force-pushed
the
filecache-sdk-upgrade
branch
from
69ff02d to
f4ca661
Compare
This changes updates filecache's internal types to use the AWS SDK Go v2's types, while preserving the external interface used by /pkg/token. This will simplify the future project-wide change for AWS SDK Go v2. Signed-off-by: Micah Hausler <[email protected]>
micahhausler
force-pushed
the
filecache-sdk-upgrade
branch
from
f4ca661 to
9cdf38d
Compare
k8s-ci-robot
added
size/L
| options.ClusterID, | ||
| profile, | ||
| options.AssumeRoleARN, | ||
| filecache.V1CredentialToV2Provider(sess.Config.Credentials)); err == nil { |
There was a problem hiding this comment.
for my education: is the filecache intended to be v1 format until some future time?
reason for asking: at a future point(or in this PR) invalidate the filecache and use v2 format directly?
There was a problem hiding this comment.
Talked to Micah offline. The change as is is backward compatible. We can invalidate the cache if v1 creds are found in a later tag. The change will be backward incompatible because rollback will not work when filecache is sdkv2 creds.
| SessionToken: val.SessionToken, | ||
| Source: val.ProviderName, | ||
| CanExpire: false, | ||
| // Don't have account ID |
There was a problem hiding this comment.
for my recollection: does the struct not have accountId? or having account ID breaks any usecase?
There was a problem hiding this comment.
The v1 struct does not have an account ID, v2 does. It won't break anything to not include it
|
/lgtm /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jyotimahapatra, micahhausler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Update filecache to use AWS SDK Go V2 with wrappers
This changes updates filecache's internal types to use the AWS SDK Go v2's types, while preserving the external interface used by /pkg/token.This will simplify the future project-wide change for AWS SDK Go v2.
Depends on #755 to be merged first
Which issue(s) this PR fixes
First change toward #736