fix: resize filesystem if cloned volume capacity is larger than the source volume

[sunpa93]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #528

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[k8s-ci-robot]

Welcome @sunpa93!

It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sunpa93. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/ok-to-test

[andyzhangx]

thanks, with this PR, volume cloning feature should be ready.
And don't forget to git rebase -i HEAD~7 to squash all commits for this PR.

[andyzhangx]

@nearora-msft that reminds me that we should filter out all os disks(has _OsDisk_ in disk name), ListVolumes should not return os disk, that's a bug:

I0112 01:42:55.898001    7895 utils.go:84] GRPC call: /csi.v1.Controller/ListVolumes
I0112 01:42:55.898027    7895 utils.go:85] GRPC request: {}
I0112 01:42:55.973836    7895 utils.go:90] GRPC response: {"entries":[{"status":{},"volume":{"volume_id":"/subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/azuredisk-csi-driver-test-520f6f1e-5477-11eb-88d4-7ec16ad5bdf3/providers/Microsoft.Compute/disks/sanity"}},{"status":{"published_node_ids":["sanity-test-node"]},"volume":{"volume_id":"/subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/azuredisk-csi-driver-test-520f6f1e-5477-11eb-88d4-7ec16ad5bdf3/providers/Microsoft.Compute/disks/sanity-test-node_OsDisk_1_0c5cbb6a1bbe4e8e9d400c5ed05a1fa8"}}]}

Is filtering on the diskName the only option? Isn't there a flag or property that we can use to filter it?

I don't see there is other way since os disk is just a normal disk returned by ListByResourceGroup

[nearora-msft]

@nearora-msft that reminds me that we should filter out all os disks(has _OsDisk_ in disk name), ListVolumes should not return os disk, that's a bug:

I0112 01:42:55.898001    7895 utils.go:84] GRPC call: /csi.v1.Controller/ListVolumes
I0112 01:42:55.898027    7895 utils.go:85] GRPC request: {}
I0112 01:42:55.973836    7895 utils.go:90] GRPC response: {"entries":[{"status":{},"volume":{"volume_id":"/subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/azuredisk-csi-driver-test-520f6f1e-5477-11eb-88d4-7ec16ad5bdf3/providers/Microsoft.Compute/disks/sanity"}},{"status":{"published_node_ids":["sanity-test-node"]},"volume":{"volume_id":"/subscriptions/0e46bd28-a80f-4d3a-8200-d9eb8d80cb2e/resourceGroups/azuredisk-csi-driver-test-520f6f1e-5477-11eb-88d4-7ec16ad5bdf3/providers/Microsoft.Compute/disks/sanity-test-node_OsDisk_1_0c5cbb6a1bbe4e8e9d400c5ed05a1fa8"}}]}

Is filtering on the diskName the only option? Isn't there a flag or property that we can use to filter it?

I don't see there is other way since os disk is just a normal disk returned by ListByResourceGroup

Probably we can use this parameter to check if its an OS disk or not. What do you say? This param is only populated for OS disks as per the docs.
https://docs.microsoft.com/en-us/rest/api/compute/disks/list#hypervgeneration

Created an issue for tracking : #678

[andyzhangx]

@nearora-msft that's a little tricky IMO, filter out by diskName should be clear enough

[sunpa93]

/retest

[sunpa93]

/retest

[sunpa93]

/retest

[andyzhangx]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment