Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flag panic if a flag is defined after being set #997

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix: flag panic if a flag is defined after being set #997

merged 1 commit into from
Aug 28, 2023

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Aug 24, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
golang 1.21 introduced a fix to flag: golang/go@0040183, which makes the Set fail loudly (panic) if it happened before the definition. Before go1.21 it just fails silently.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: flag panic if a flag is defined after being set

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2023
@cvvz
Copy link
Member Author

cvvz commented Aug 24, 2023

/retest

@andyzhangx
Copy link
Member

can you squash commits? thanks.

@andyzhangx
Copy link
Member

btw, do we need to cherrypick and fix on other csi drivers?

@cvvz
Squashed commit of the following:
e73a687 
commit e405f76
Author: weizhichen <[email protected]>
Date:   Thu Aug 24 09:35:14 2023 +0000

    fix

commit de03fda
Author: weizhichen <[email protected]>
Date:   Thu Aug 24 09:33:26 2023 +0000

    fix

commit 2389047
Author: weizhichen <[email protected]>
Date:   Thu Aug 24 08:20:30 2023 +0000

    fix

commit 3834b62
Author: weizhichen <[email protected]>
Date:   Thu Aug 24 08:11:12 2023 +0000

    fix log panic
@cvvz
Copy link
Member Author

cvvz commented Aug 25, 2023 •
edited
Loading

do we need to cherrypick and fix on other csi drivers?

Other CSI driver doesn't have such usage. So, I think not.

andyzhangx
andyzhangx approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 23765a6 into kubernetes-sigs:master Aug 28, 2023
10 checks passed
@andyzhangx
Copy link
Member

/cherrypick release-1.20

@andyzhangx
Copy link
Member

/cherrypick release-1.19

@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #1052

In response to this:

/cherrypick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 15, 2023
Closed
Merged
@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #1053

In response to this:

/cherrypick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cvvz @andyzhangx @k8s-ci-robot @k8s-infra-cherrypick-robot