Chore: set batch size to great or equal to 1

[MartinForReal]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Chore: set batch size to great or equal to 1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[MartinForReal]

/cherrypick release-1.32

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.32 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[MartinForReal]

/cherrypick release-1.31

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.31 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[MartinForReal]

/cherrypick release-1.30

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.30 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nilo19]

can we add unit test?

[mainred]

How about we default vm batch size to 1 instead of 0? which makes more sense.
0 carries the same meaning as 1 in implementation, but is error-prone.

[feiskyer]

How about we default vm batch size to 1 instead of 0? which makes more sense.

@MartinForReal could you change the default value (e.g. during config initialization) and add some unit tests?

[MartinForReal]

How about we default vm batch size to 1 instead of 0? which makes more sense.
0 carries the same meaning as 1 in implementation, but is error-prone.

For default value please see line 2332,
We don't set default value for config. Do you think it is sufficient in current scenario?

[coveralls]

coverage: 76.603% (+0.004%) from 76.599%
when pulling f782f95 on MartinForReal:shafan/batchsize
into a6e74d8 on kubernetes-sigs:master.

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MartinForReal,andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

/retest

[MartinForReal]

/retest

[MartinForReal]

/retest

[k8s-infra-cherrypick-robot]

@MartinForReal: new pull request created: #8055

In response to this:

/cherrypick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: new pull request created: #8056

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: #8035 failed to apply on top of branch "release-1.30":

Applying: set batch size to great or equal to 1
Using index info to reconstruct a base tree...
M	pkg/provider/azure_vmss.go
M	pkg/provider/azure_vmss_test.go
A	pkg/provider/config/azure.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/provider/config/azure.go deleted in HEAD and modified in set batch size to great or equal to 1. Version set batch size to great or equal to 1 of pkg/provider/config/azure.go left in tree.
Auto-merging pkg/provider/azure_vmss_test.go
Auto-merging pkg/provider/azure_vmss.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 set batch size to great or equal to 1

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.