Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump CAPI to v1.8.5 #632

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Nov 5, 2024

What this PR does / why we need it:
Follows: https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.7-to-v1.8 to bump Cluster API to v1.8.5, the latest version in v1.8.x series, as is now.

Additionally, there were a couple of changes included in the same patch, since there was a circular dependency among cluster API and controller runtime dependencies:

  1. The sigs.k8s.io/controller-runtime/pkg/config/v1alpha1 package utilized in v1alpha1 of our API has been deprecated (refer to RFC: Deprecation and removal of ComponentConfig controller-runtime#895). Consequently, updating to a new Cluster API version, which removes ComponentConfig, forced us to develop a custom config loader for the v1alpha1 API. It’s important to note that we successfully transitioned from ComponentConfig to its new alternative in v1alpha2 of our API, as detailed in v1alpha2? #167 (comment), but package usage remained in v1alpha1 API.

  2. The size of this patch has increased due to several interdependencies that could not be split into separate PRs (the Cluster API update requires a new controller runtime, which in turn needs a custom config). Despite this, hopefully reviewing it should be still relatively straight-forward. Key reasons for the expanded diffs include:

    • Core components in the YAML files have been swapped: from v1.5.4 & v1.6.0 to v1.7.7 & v1.8.0.
    • The upgrade of controller-gen introduced significant changes in the Custom Resource Definitions (CRDs).
  3. Due to these necessary changes to v1alpha1, the api-diff CI will fail.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #566

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit c7b9c24
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/6732f756ea85e70008a4263b
😎 Deploy Preview https://deploy-preview-632--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@furkatgofurov7 furkatgofurov7 force-pushed the bump-capi-1-8 branch 3 times, most recently from 266b483 to 36f98fb Compare November 11, 2024 15:16
@furkatgofurov7 furkatgofurov7 changed the title 🌱 Bump CAPI to v1.8.4 🌱 Bump CAPI to v1.8.5 Nov 11, 2024
@furkatgofurov7 furkatgofurov7 force-pushed the bump-capi-1-8 branch 2 times, most recently from 6dc4dbc to 29f4bd3 Compare November 11, 2024 18:12
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7 furkatgofurov7 force-pushed the bump-capi-1-8 branch 2 times, most recently from 86dba88 to 3b6be2b Compare November 11, 2024 21:51
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-operator-apidiff-main c7b9c24 link false /test pull-cluster-api-operator-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@salasberryfin
Copy link

Thanks @furkatgofurov7.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 227ed7ea918fd5106eed36170b2fb6330d76a976

@alexander-demicev
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit d630332 into kubernetes-sigs:main Nov 12, 2024
17 of 18 checks passed
@furkatgofurov7 furkatgofurov7 deleted the bump-capi-1-8 branch November 12, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPI v1.8.0-beta.0 has been released and is ready for testing
4 participants