Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for identity service in GCPManagedControlPlane #1366

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat: add support for identity service in GCPManagedControlPlane #1366

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f638a18
feat: add support for identity service in GCPManagedControlPlane
afarbos Nov 12, 2024
56e8283
make generate
afarbos Nov 12, 2024
6ef3edf
Update exp/api/v1beta1/gcpmanagedcontrolplane_types.go
afarbos Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cloud/services/container/clusters/reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,9 @@ func (s *Service) createCluster(ctx context.Context, log *logr.Logger) error {
Autopilot: &containerpb.Autopilot{
Enabled: s.scope.GCPManagedControlPlane.Spec.EnableAutopilot,
},
IdentityServiceConfig: &containerpb.IdentityServiceConfig{
Enabled: s.scope.GCPManagedControlPlane.Spec.EnableIdentityService,
},
ReleaseChannel: &containerpb.ReleaseChannel{
Channel: convertToSdkReleaseChannel(s.scope.GCPManagedControlPlane.Spec.ReleaseChannel),
},
Expand Down
4 changes: 4 additions & 0 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_gcpmanagedcontrolplanes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ spec:
description: EnableAutopilot indicates whether to enable autopilot
for this GKE cluster.
type: boolean
enableIdentityService:
description: EnableIdentityService indicates whether to enable Identity
Service component for this GKE cluster.
type: boolean
endpoint:
description: Endpoint represents the endpoint used to communicate
with the control plane.
Expand Down
5 changes: 4 additions & 1 deletion exp/api/v1beta1/gcpmanagedcontrolplane_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2022 The Kubernetes Authors.
Copyright, 2022 The Kubernetes Authors.
afarbos marked this conversation as resolved.
Show resolved Hide resolved

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -133,6 +133,9 @@ type GCPManagedControlPlaneSpec struct {
// EnableAutopilot indicates whether to enable autopilot for this GKE cluster.
// +optional
EnableAutopilot bool `json:"enableAutopilot"`
// EnableIdentityService indicates whether to enable Identity Service component for this GKE cluster.
// +optional
EnableIdentityService bool `json:"enableIdentityService"`
// ReleaseChannel represents the release channel of the GKE cluster.
// +optional
ReleaseChannel *ReleaseChannel `json:"releaseChannel,omitempty"`
Expand Down