Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo to prerequisites.md #613

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Fix Typo to prerequisites.md #613

merged 1 commit into from
Jun 12, 2022

Conversation

hrittikhere
Copy link
Contributor

/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 4, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hrittikhere / name: Hrittik Roy (e69a912)

@k8s-ci-robot
Copy link
Contributor

Welcome @hrittikhere!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @hrittikhere. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2022
@hrittikhere
Copy link
Contributor Author

/assign @cpanato

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2022
@cpanato
Copy link
Member

cpanato commented Jun 5, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 5, 2022
@hrittikhere
Copy link
Contributor Author

@cpanato do I need to do anything for the broken links? I didn't introduce these changes and also if I visit these links the site opens.

@cpanato
Copy link
Member

cpanato commented Jun 5, 2022

@hrittikhere will be good to fix that :)

@hrittikhere
Copy link
Contributor Author

@cpanato so I am replacing this with https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key as we don't need an enterprise edition doc. Also how to test lint locally?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2022
@hrittikhere hrittikhere requested a review from cpanato June 5, 2022 17:31
@hrittikhere hrittikhere mentioned this pull request Jun 7, 2022
3 tasks
@cpanato
Copy link
Member

cpanato commented Jun 8, 2022

/retest

@hrittikhere
Copy link
Contributor Author

hrittikhere commented Jun 9, 2022

Hey @cpanato
I think there might be some issue with the action implementation as the link can be perfectly accessed via a WebUI. Now after further investigation via curl we can see:

<div id='message'>
<h2>The request is blocked.</h2></div>
<div id='errorref'>
<span>0/ByiYgAAAAD0Jl+OyjIrTI2PolL1vAbHTU5aMjIxMDYwNjE0MDI5ADU5NmQ3OGEyLWNhNWYtNDc5ZC1iY2RjLTA4MzU4MzMxNzRiMg==</span>
</div>

image

So the request is blocked via GitHub which we don't have any control over except to file an issue with the author of https://github.com/gaurav-nelson/github-action-markdown-link-check

Do you have any better alternatives or suggestions?

@hrittikhere
Copy link
Contributor Author

I found a lead and we need to move forward with this change: tcort/markdown-link-check#201 (comment)

This issue is not just bothering us as we see at gaurav-nelson/github-action-markdown-link-check#136

If you want I can look into it and file a PR

@cpanato
Copy link
Member

cpanato commented Jun 10, 2022

sounds good

@hrittikhere
Copy link
Contributor Author

Filling a new PR for the link checks? Or should I add in the similar?

@cpanato
Copy link
Member

cpanato commented Jun 10, 2022

open a new pr

@hrittikhere
Copy link
Contributor Author

@cpanato I have created an issue (for ref in future if required) and also a PR here: #623

It runs locally well:
image

Please let me know if you have any question for these two PRs :)

@cpanato
Copy link
Member

cpanato commented Jun 10, 2022

please rebase when #623 gets merged
thanks

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2022
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits into one

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@hrittikhere
Copy link
Contributor Author

Hey @cpanato
Can you please check if I did the rebase correctly? Also, the link checks work well as you can see in the action

I would love to retest once at this PR: #621

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 10, 2022
@hrittikhere hrittikhere requested a review from cpanato June 11, 2022 11:35
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hrittikhere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit e54141e into kubernetes-sigs:main Jun 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants