-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typo to prerequisites.md
#613
Conversation
|
Welcome @hrittikhere! |
Hi @hrittikhere. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @cpanato |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/ok-to-test
/approve
/lgtm
/release-note-none |
@cpanato do I need to do anything for the broken links? I didn't introduce these changes and also if I visit these links the site opens. |
@hrittikhere will be good to fix that :) |
@cpanato so I am replacing this with https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key as we don't need an enterprise edition doc. Also how to test lint locally? |
/retest |
Hey @cpanato <div id='message'>
<h2>The request is blocked.</h2></div>
<div id='errorref'>
<span>0/ByiYgAAAAD0Jl+OyjIrTI2PolL1vAbHTU5aMjIxMDYwNjE0MDI5ADU5NmQ3OGEyLWNhNWYtNDc5ZC1iY2RjLTA4MzU4MzMxNzRiMg==</span>
</div> So the request is blocked via GitHub which we don't have any control over except to file an issue with the author of https://github.com/gaurav-nelson/github-action-markdown-link-check Do you have any better alternatives or suggestions? |
I found a lead and we need to move forward with this change: tcort/markdown-link-check#201 (comment) This issue is not just bothering us as we see at gaurav-nelson/github-action-markdown-link-check#136 If you want I can look into it and file a PR |
sounds good |
Filling a new PR for the link checks? Or should I add in the similar? |
open a new pr |
please rebase when #623 gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash the commits into one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, hrittikhere The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind documentation