-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump CAPI to v1.4.4 #969
Conversation
a39fbb9
to
c0a44b5
Compare
/test pull-cluster-api-provider-gcp-verify |
c0a44b5
to
998d2bb
Compare
998d2bb
to
328b7d2
Compare
@cpanato - fyi, i will fix the e2e on Monday |
It looks like the E2Es are failing due to kind. |
c3ba331
to
fed008c
Compare
/test pull-cluster-api-provider-gcp-e2e-test |
fed008c
to
c422582
Compare
c422582
to
413c050
Compare
Signed-off-by: Richard Case <[email protected]>
413c050
to
f7d3805
Compare
@richardcase: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cpanato - do you think it's ok to override the apidiff for this? |
agree! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! this is super nice thank you
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@richardcase i tomorrow i will create the jobs to prepare for the 1.4 release, do we want anything else in the new release? |
Thanks @cpanato . I'll go through the open PRs and see if there are any must haves. |
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
This bumps CAPI to v1.4.4
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: