Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump CAPI to v1.4.4 #969

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This bumps CAPI to v1.4.4

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Bump CAPI to v1.4.4

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2023
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-gcp-verify

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2023
@richardcase
Copy link
Member Author

@cpanato - fyi, i will fix the e2e on Monday

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@damdo
Copy link
Member

damdo commented Jul 10, 2023

It looks like the E2Es are failing due to kind.
Which is potentially the same issue we faced in kubernetes-sigs/cluster-api-provider-aws#4372
Should we take a similar approach to try and move this one forward @richardcase ?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-gcp-e2e-test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2023

@richardcase: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-apidiff f7d3805 link false /test pull-cluster-api-provider-gcp-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardcase
Copy link
Member Author

@cpanato - do you think it's ok to override the apidiff for this?

@cpanato
Copy link
Member

cpanato commented Jul 11, 2023

agree!
but we dont need because that is not required

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! this is super nice thank you
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2131458 into kubernetes-sigs:main Jul 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Jul 11, 2023
@cpanato
Copy link
Member

cpanato commented Jul 11, 2023

@richardcase i tomorrow i will create the jobs to prepare for the 1.4 release, do we want anything else in the new release?

@richardcase
Copy link
Member Author

@richardcase i tomorrow i will create the jobs to prepare for the 1.4 release, do we want anything else in the new release?

Thanks @cpanato . I'll go through the open PRs and see if there are any must haves.

@cpanato
Copy link
Member

cpanato commented Jul 12, 2023

@richardcase i tomorrow i will create the jobs to prepare for the 1.4 release, do we want anything else in the new release?

Thanks @cpanato . I'll go through the open PRs and see if there are any must haves.

kubernetes/test-infra#30067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants