✨ feat: reconcile pre-existing router

[simonostendorf]

What this PR does / why we need it:

Currently only pre existing networks and subnets are reconciled and not a pre existing router.

I think it is a good idea to also reconcile pre-existing routers and put them in the status. This is useful for debugging, reading info from the status (e.g. outgoing router ip of the cluster) and if the router ip is written to the status, it can be used for the lb allowlist.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

none

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

[k8s-ci-robot]

Hi @simonostendorf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	e400aad
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67860970f83e72000876adff
😎 Deploy Preview	https://deploy-preview-2338--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[EmilienM]

/ok-to-test

[EmilienM]

what happens if we don't do that?

[simonostendorf]

I dont remember why I added this. But when I read this now I think it doesnt make sense because it forces the user to provide a router reference otherwise they would get logs that the router couldnt be found over and over again.

[EmilienM]

yeah this block doesn't make sense to me.

[EmilienM]

Sorry it took me time to review it. I think this is mostly good, I have a few comments inline.
Thanks for taking the time to fix this use case!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment