Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
chrischdi committed Jun 18, 2024
1 parent d290519 commit 1604e84
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions test/framework/vmoperator/vmoperator.go
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ func ReconcileDependencies(ctx context.Context, c client.Client, dependenciesCon
return retryError
}

// Create VirtualMachineClass in K8s and bind it to the user namespace
// Create VirtualMachineClass in K8s
for _, vmc := range config.Spec.VirtualMachineClasses {
vmClass := &vmoprv1.VirtualMachineClass{
ObjectMeta: metav1.ObjectMeta{
Expand Down Expand Up @@ -394,10 +394,10 @@ func ReconcileDependencies(ctx context.Context, c client.Client, dependenciesCon
}
}

// Create a ContentLibrary in K8s and in vCenter, bind it to the K8s namespace
// Create a ContentLibrary in K8s and in vCenter,
// This requires a set of objects in vCenter(or vcsim) as well as their mapping in K8s
// - vCenter: a Library containing an Item
// - k8s: ContentLibraryProvider, ContentSource (both representing the library), a VirtualMachineImage (representing the Item)
// - k8s: a VirtualMachineImage (representing the Item)

restClient := rest.NewClient(s.Client.Client)
if err := restClient.Login(ctx, url.UserPassword(config.Spec.VCenter.Username, config.Spec.VCenter.Password)); err != nil {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ func Test_Reconcile_VirtualMachine(t *testing.T) {
// Those values are required to unblock provisioning of node
BiosUUID: "foo",
Network: &vmoprv1.VirtualMachineNetworkStatus{
// TODO(chrischdi): if not works, we also have to add an interface
PrimaryIP4: "1.2.3.4",
},
PowerState: vmoprv1.VirtualMachinePowerStateOn,
Expand Down

0 comments on commit 1604e84

Please sign in to comment.