Skip to content

Commit

Permalink
FIXME: comment out happy path to test unhappy path
Browse files Browse the repository at this point in the history
  • Loading branch information
chrischdi committed May 16, 2024
1 parent 5178278 commit b392333
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/framework/log/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ func (c *MachineLogCollector) CollectInfrastructureLogs(_ context.Context, _ cli
}

func (c *MachineLogCollector) machineIPAddresses(ctx context.Context, m *clusterv1.Machine) ([]string, error) {
for _, address := range m.Status.Addresses {
if address.Type != clusterv1.MachineExternalIP {
continue
}
return []string{address.Address}, nil
}
// for _, address := range m.Status.Addresses {

Check failure on line 97 in test/framework/log/collector.go

View workflow job for this annotation

GitHub Actions / lint (test)

commentedOutCode: may want to remove commented-out code (gocritic)

Check failure on line 97 in test/framework/log/collector.go

View workflow job for this annotation

GitHub Actions / lint (test)

commentedOutCode: may want to remove commented-out code (gocritic)
// if address.Type != clusterv1.MachineExternalIP {
// continue
// }
// return []string{address.Address}, nil
// }

vmObj, err := c.Finder.VirtualMachine(ctx, m.GetName())
if err != nil {
Expand Down

0 comments on commit b392333

Please sign in to comment.