✨ reconcile IPAddressClaims earlier #1752
Conversation
IPAddressClaims must be fulfilled before a VM can be powered on. This could take some time depending on the IPAM Provider. By creating these claims first we can give the provider time to fulfill these while the VM is cloning, reducing the overall wait time for a VM to be ready. Signed-off-by: Aidan Obley <[email protected]> Co-authored-by: Edwin Xie <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
Hi @adobley. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
adobley
changed the title
|
/lgtm This just creates the IPAddressClaim objects for the VMs earlier in the reconcile loop so as to give enough time for the IPAddresses to be realized by the IPAM controllers. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: srm09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
What this PR does / why we need it:
IPAddressClaims must be fulfilled before a VM can be powered on. This
could take some time depending on the IPAM Provider. By creating these
claims first we can give the provider time to fulfill these while the VM
is cloning, reducing the overall wait time for a VM to be ready.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1690
Special notes for your reviewer:
We rebased on the e2e tests PR #1667 to validate this work, but dropped that commit before opening this PR
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: