🐛 envtest: Dynamically load CRDs using golang resolvers #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/retest-required |
|
/retest |
sbueringer
reviewed
Jun 7, 2023
k8s-ci-robot
added
the
needs-rebase
|
Rebased |
randomvariable
force-pushed
the
crd-fixup
branch
from
505a21c
to
4379def
Compare
k8s-ci-robot
removed
the
needs-rebase
randomvariable
changed the title
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm /retest-required |
k8s-ci-robot
added
lgtm
Accounts for when GOPATH does not contain source files due to other system or user configurations for the Go compiler. Signed-off-by: Naadir Jeewa <[email protected]>
randomvariable
force-pushed
the
crd-fixup
branch
from
4379def
to
08923bd
Compare
k8s-ci-robot
removed
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accounts for when GOPATH does not contain source files due to other system or user configurations for the Go compiler.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1930
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: