Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] 🐛 CI: Introduces the thumbprint value in CI yaml #1985

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[release-1.5] 🐛 CI: Introduces the thumbprint value in CI yaml #1985

merged 1 commit into from
Jul 11, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1860

/assign chrischdi

NONE

@srm09
Introduces the thumbprint value in CI yaml
437bc60 
The value gets used to run the CI e2e tests. The value in the
vsphere-dev.yaml is a placeholder which needs to be updated when running
the tests locally.

Signed-off-by: Sagar Muchhal <[email protected]>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 11, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2023
@chrischdi
Copy link
Member

Note: this PR is required to fix CI which is red due to:

Failed to run clusterctl config cluster
Unexpected error:
    <*yamlprocessor.errMissingVariables | 0xc000ccc090>: {
        Missing: [
            "VSPHERE_TLS_THUMBPRINT",
        ],
    }
    value for variables [VSPHERE_TLS_THUMBPRINT] is not set. Please set the value using os environment variables or the clusterctl config file
occurred
/home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/clusterctl/client.go:216}

@randomvariable
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9d30058 into kubernetes-sigs:release-1.5 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxRink MaxRink Awaiting requested review from MaxRink

@yastij yastij Awaiting requested review from yastij

Assignees

@chrischdi chrischdi

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @chrischdi @randomvariable @k8s-ci-robot @srm09