[release-1.5] 🐛 Fix datastore selection based on StoragePolicy #2001
Conversation
When storage policy is specified, CAPV will fetch compatible datastores and randomly selects one, however the return set also contains datastore cluster. This will leads to long-time retries and even clone failures. Signed-off-by: Gong Zhang <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@chrischdi Strange looks like we still get the categories flake even though we cherry-picked the PR into this branch: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-vsphere/2001/pull-cluster-api-provider-vsphere-verify-gen/1679356407687680000 I'll go through all branches and ensure we have them everywhere |
Realized we have them everywhere (just not on my local branches 😂) I don't understand how this issue can still occur as Prow should test this PR merged into release-1.5. But maybe that assumption is wrong? |
|
Ah got it. The problem is that the checked-in CR YAML doesn't have the category :) |
|
Fix PR: #2003 |
|
/retest-required |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This is an automated cherry-pick of #1937
/assign sbueringer