[release-1.7] 🌱 Refactor how tools are built to align with CAPI and get rid of tools go.mod #2094
Conversation
… tools installation. * Uses hack/go-install.sh to install: * setup-envtest * conversion-gen * go-apidiff * ginkgo * kind * Uses hack/go-tools-build.sh to install: * conversion-verifier * release-notes * Adjusts help display function to core CAPI * Reorders definitions in Makefile to improve comparability to core CAPI Makefile * Implements hack/go-tools-build.sh to install binaries from sigs.k8s.io/cluster-api/hack/tools/... * Removes Makefile and go module in hack/tools
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
/test help |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Let's see if that one works: /test pull-cluster-api-provider-vsphere-conformance-1-7 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Manual cherry-pick of #2080
Remove go module in hack/tools and align to core CAPI with regards to tools installation
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #2060
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: