[release-1.5] 🌱 Refactor how tools are built to align with CAPI and get rid of tools go.mod #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
chrischdi
force-pushed
the
pr-makefile-sync-1-5
branch
from
f3ff244
to
721c92e
Compare
|
/hold to bump go-apidiff |
k8s-ci-robot
added
the
do-not-merge/hold
chrischdi
force-pushed
the
pr-makefile-sync-1-5
branch
from
721c92e
to
f679988
Compare
|
/hold cancel Bumped go-apidiff to the same as release-1.7 and main |
k8s-ci-robot
removed
the
do-not-merge/hold
sbueringer
reviewed
Jul 26, 2023
… tools installation. * Uses hack/go-install.sh to install: * setup-envtest * conversion-gen * go-apidiff * ginkgo * kind * Uses hack/go-tools-build.sh to install: * conversion-verifier * release-notes * Adjusts help display function to core CAPI * Reorders definitions in Makefile to improve comparability to core CAPI Makefile * Implements hack/go-tools-build.sh to install binaries from sigs.k8s.io/cluster-api/hack/tools/... * Removes Makefile and go module in hack/tools
chrischdi
force-pushed
the
pr-makefile-sync-1-5
branch
from
f679988
to
471c1d7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #2080
Remove go module in hack/tools and align to core CAPI with regards to tools installation
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #2060
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: