Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement image promotion sync Makefile with core CAPI #2101

Merged
merged 1 commit into from
Jul 28, 2023
Merged

✨ Implement image promotion sync Makefile with core CAPI #2101

merged 1 commit into from
Jul 28, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 27, 2023 •
edited
Loading

What this PR does / why we need it:
Still testing if everything works

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2051

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 27, 2023
@sbueringer sbueringer force-pushed the pr-image-promo branch 5 times, most recently from beb146e to 1ad4779 Compare July 27, 2023 13:48
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-verify-crds 1ad4779 link false /test pull-cluster-api-provider-vsphere-verify-crds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e
  • /test pull-cluster-api-provider-vsphere-full-e2e
  • /test pull-cluster-api-provider-vsphere-integration-test
  • /test pull-cluster-api-provider-vsphere-test
  • /test pull-cluster-api-provider-vsphere-verify-main
  • /test pull-cluster-api-provider-vsphere-verify-markdown
  • /test pull-cluster-api-provider-vsphere-verify-shell

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main
  • /test pull-cluster-api-provider-vsphere-conformance

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e
  • pull-cluster-api-provider-vsphere-integration-test
  • pull-cluster-api-provider-vsphere-test
  • pull-cluster-api-provider-vsphere-verify-markdown
  • pull-cluster-api-provider-vsphere-verify-shell

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-verify-main

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 27, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-verify-main

(@randomvariable just fyi, accidentally I created this job without always_run: true, I'll fix that up within the next few days when I audit the ProwJobs)

@sbueringer sbueringer changed the title [WIP] ✨ Implement image promotion sync Makefile with core CAPI ✨ Implement image promotion sync Makefile with core CAPI Jul 27, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2023
srm09
srm09 reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@srm09 srm09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional lgtm barring changes to Makefile which I would need to go over again, but looks good on first pass.
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@sbueringer
Copy link
Member Author

sbueringer commented Jul 27, 2023 •
edited
Loading

Conditional lgtm barring changes to Makefile which I would need to go over again, but looks good on first pass. /lgtm /hold

Yup Makefile is very hard to delta-review. Basically I synced with the one from core CAPI and tried to preserve existing features (e.g. make dev-manifests, the flavor targets etc)

@randomvariable
Copy link
Member

/approve

/assign @chrischdi for cross-review

@k8s-ci-robot
Copy link
Contributor

@randomvariable: GitHub didn't allow me to assign the following users: for, cross-review.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/approve

/assign @chrischdi for cross-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
chrischdi
chrischdi reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit / optional, because I'm okay to just keep it in sync with CAPI and it should not matter for a release :-)

/lgtm

Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2023
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-verify-main

@sbueringer
Copy link
Member Author

sbueringer commented Jul 28, 2023 •
edited
Loading

@randomvariable @srm09 Can we move ahead with this PR?

(sorry for being pushy, just would unblock a bunch of work to get the new release machinery finalized and further ProwJob cleanups)

I'm fine with addressing further findings in follow-up PRs.

@srm09
Copy link
Contributor

srm09 commented Jul 28, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit f2ba55c into kubernetes-sigs:main Jul 28, 2023
4 checks passed
@sbueringer sbueringer deleted the pr-image-promo branch July 28, 2023 18:43
This was referenced Jul 31, 2023
Merged
Merged
Merged
erkanerol added a commit to giantswarm/retagger that referenced this pull request May 20, 2024
@erkanerol
Update image registry for CAPV manager
18c5335 
The registry for CAPV images is changed in this PR kubernetes-sigs/cluster-api-provider-vsphere#2101

Old and new images exist in the new registry.
@erkanerol erkanerol mentioned this pull request May 20, 2024
Merged
erkanerol added a commit to giantswarm/retagger that referenced this pull request May 21, 2024
@erkanerol
Update image registry for CAPV manager (#1011)
bc17754 
The registry for CAPV images is changed in this PR kubernetes-sigs/cluster-api-provider-vsphere#2101

Old and new images exist in the new registry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 srm09 left review comments

@chrischdi chrischdi chrischdi left review comments

@MaxRink MaxRink Awaiting requested review from MaxRink

Assignees

@chrischdi chrischdi

@srm09 srm09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @k8s-ci-robot @randomvariable @chrischdi @srm09