🐛 clustermodules: prevent creation of new modules if DoesExist returns an error #2185
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
chrischdi
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
chrischdi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
chrischdi
force-pushed
the
pr-clustermodule-doesexist-leak
branch
from
fe98aab
to
dbb2e28
Compare
|
/test help |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
chrischdi
force-pushed
the
pr-clustermodule-doesexist-leak
branch
from
dbb2e28
to
0a51d7c
Compare
k8s-ci-robot
added
size/L
|
Thx! /lgtm |
|
/cherry-pick release-1.7 |
k8s-ci-robot
added
the
lgtm
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM label has been added. Git tree hash: b0159aadf0bb478cd0cc21439f839e92514c50b1
|
|
/cherry-pick release-1.6 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.5 |
k8s-ci-robot
added
the
approved
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-vsphere-e2e-main |
|
@sbueringer: new pull request created: #2204 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sbueringer: new pull request created: #2205 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sbueringer: new pull request created: #2206 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Ensures to preserve existing cluster modules if
DoesExistreturns an error. Instead bubble up the error in theClusterModulesAvailableCondition.Also adds unit tests for the cases when:
DoesExist(above case)DoesExistsreturnsfalse, nil) and need to be recreated.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2184
/assign sbueringer