Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] ✨ Improve session handling with a secure session key #2192

Conversation

zhanggbj
Copy link
Contributor

@zhanggbj zhanggbj commented Aug 9, 2023

What this PR does / why we need it:
Manually cherry-pick #2154 to resolve conflicts

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 9, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2023
Manually cherry-pick kubernetes-sigs#2154 to resolve conflicts

Signed-off-by: Gong Zhang <[email protected]>
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2023
@zhanggbj zhanggbj force-pushed the cherry-pick-2154-to-release-1.6 branch from cbf0a22 to cf9c580 Compare August 9, 2023 03:19
@zhanggbj zhanggbj changed the title [release-1.6] Improve session handling with a secure session key ✨ [release-1.6] Improve session handling with a secure session key Aug 9, 2023
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 002a202bdedd4e7bf505b84c0568a2e556e144c9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@sbueringer
Copy link
Member

/retest

@sbueringer
Copy link
Member

/test pull-cluster-api-provider-vsphere-test-integration-release-1-6

@sbueringer
Copy link
Member

/test pull-cluster-api-provider-vsphere-e2e-release-1-6

@sbueringer
Copy link
Member

/test pull-cluster-api-provider-vsphere-test-release-1-6

@sbueringer
Copy link
Member

/test pull-cluster-api-provider-vsphere-verify-release-1-6

@zhanggbj
Copy link
Contributor Author

zhanggbj commented Aug 9, 2023

/retest

@sbueringer sbueringer changed the title ✨ [release-1.6] Improve session handling with a secure session key [release-1.6] ✨ Improve session handling with a secure session key Aug 9, 2023
@sbueringer
Copy link
Member

Just did a small change to trigger the PR title verification action. Somehow wasn't triggered before

@k8s-ci-robot k8s-ci-robot merged commit 6321792 into kubernetes-sigs:release-1.6 Aug 9, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants