Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update compatibility in README.md #2208

Merged
merged 1 commit into from
Aug 14, 2023
Merged

🌱 Update compatibility in README.md #2208

merged 1 commit into from
Aug 14, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2023
sbueringer
sbueringer commented Aug 10, 2023
View reviewed changes
README.md Outdated
| CAPV v1beta1 (v1.5) | ☓ | ☓ | ☓ | ✓ | ✓ | ☓ |
| CAPV v1beta1 (v1.6) | ☓ | ☓ | ☓ | ✓ | ✓ | ☓ |
| CAPV v1beta1 (v1.7) | ☓ | ☓ | ☓ | ✓ | ✓ | ☓ |
| CAPV v1beta1 (v1.8) | ☓ | ☓ | ☓ | ☓ | ☓ | ✓ |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this was filled out before, but I would stick with supporting what we test which is the combination CAPV v1.8 & CAPI v1.5

We should probably rethink the format of this table as it doesn't scale well, but let's keep it as is for now

killianmuldoon
killianmuldoon reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me to only explicitly support what we test. If we want to expand the support matrix we should expand the test matrix.

killianmuldoon
killianmuldoon reviewed Aug 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
killianmuldoon
killianmuldoon reviewed Aug 10, 2023
View reviewed changes
README.md Outdated
| CAPV v1beta1 (v1.5) | ☓ | ☓ | ☓ | ✓ | ✓ |
| CAPV v1beta1 (v1.6) | ☓ | ☓ | ☓ | ✓ | ✓ |
| CAPV v1beta1 (v1.7) | ☓ | ☓ | ☓ | ✓ | ✓ |
| | Cluster API v1alpha3 (v0.7) | Cluster API v1alpha4 (v0.8) | Cluster API v1beta1 (v1.0) | Cluster API v1beta1 (v1.3) | Cluster API v1beta1 (v1.4) | Cluster API v1beta1 (v1.5) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also get rid of v1alpha3 and v1alpha4 from the top bar? Should make the whole thing easier to read.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh of course ups

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx for catching it

Now the table looks okay

killianmuldoon
killianmuldoon reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c98c838e829d71c1466fa9db4162401f7e38c6f9

chrischdi
chrischdi reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2bf748d into kubernetes-sigs:main Aug 14, 2023
5 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 14, 2023
@sbueringer sbueringer deleted the pr-update-docs branch August 14, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@chrischdi chrischdi chrischdi left review comments

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

@zhanggbj zhanggbj Awaiting requested review from zhanggbj

Assignees

@chrischdi chrischdi

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @chrischdi @killianmuldoon