Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 CI: add annotation with prowjob name and id to ipclaims #2210

Merged
merged 1 commit into from
Aug 15, 2023
Merged

🌱 CI: add annotation with prowjob name and id to ipclaims #2210

merged 1 commit into from
Aug 15, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Adds the prowjob name and id as annotation to ipclaims to help identifying where leaks of IPs come from.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2023
@chrischdi chrischdi force-pushed the pr-ci-ipclaim-annotation branch 3 times, most recently from 6c1fc97 to 0152f53 Compare August 14, 2023 13:00
@killianmuldoon
Copy link
Contributor

/retest

@chrischdi chrischdi force-pushed the pr-ci-ipclaim-annotation branch 2 times, most recently from 68fc6b7 to df3015f Compare August 14, 2023 13:50
@chrischdi chrischdi changed the title [WIP] 🌱 CI: add annotation with prowjob name and id to ipclaims 🌱 CI: add annotation with prowjob name and id to ipclaims Aug 14, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2023
sbueringer
sbueringer reviewed Aug 14, 2023
View reviewed changes
hack/e2e.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/e2e.sh Outdated Show resolved Hide resolved
hack/e2e.sh Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45af457289c9e7c801bcbebeb955d25a671ed32c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@sbueringer
Copy link
Member

/test pull-cluster-api-provider-vsphere-e2e-main

@k8s-ci-robot k8s-ci-robot merged commit 14c03de into kubernetes-sigs:main Aug 15, 2023
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 15, 2023
@chrischdi chrischdi deleted the pr-ci-ipclaim-annotation branch August 15, 2023 11:51
@chrischdi
Copy link
Member Author

/cherry-pick release-1.8

@chrischdi
Copy link
Member Author

/cherry-pick release-1.7

@chrischdi
Copy link
Member Author

/cherry-pick release-1.6

@chrischdi
Copy link
Member Author

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot
Copy link

@chrischdi: new pull request created: #2221

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 15, 2023
Merged
Merged
@k8s-infra-cherrypick-robot
Copy link

@chrischdi: new pull request created: #2222

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 15, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@chrischdi: new pull request created: #2223

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 15, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@chrischdi: new pull request created: #2224

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@srm09 srm09 Awaiting requested review from srm09

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@chrischdi @killianmuldoon @sbueringer @k8s-ci-robot @k8s-infra-cherrypick-robot