-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.8] 🌱 Grouped CI related cherry-picks #2225
[release-1.8] 🌱 Grouped CI related cherry-picks #2225
Conversation
docs/release/release-tasks.md
Outdated
@@ -7,13 +7,13 @@ | |||
<!-- START doctoc generated TOC please keep comment here to allow auto update --> | |||
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> | |||
|
|||
- [Prepare main branch for development of the new release](#prepare-main-branch-for-development-of-the-new-release) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to diverge from main with this change now (not saying it has to be sync, but not sure about this change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(although having the whole file sync probably makes cherry-picks easier)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll drop this. We don't update this that much / should have no conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Now this file is as sync as the other branches.
Just seemed strange to introduce an additional diff in this file in this PR
- Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
008d6b9
to
7909e05
Compare
/lgtm |
LGTM label has been added. Git tree hash: 3e4d4c8ac763fa88112f358317dfa0737d40d4ee
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a manual cherry-pick of: