🌱 Enable powerOffMode trySoft in cluster-templates and CI #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
|
/assign @killianmuldoon @chrischdi |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ed77e792c7625b59b7f067721162b0fac078382e
|
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
We introduced powerOffMode in CAPV v1.8. We ensured that the default behavior doesn't change by using "hard" as default on the CRDs.
I think it's reasonable now to start using trySoft in our cluster-templates and in CI. It's the ideal value and just changing the value in the cluster-templates doesn't break our API behavior in any way.
Also the VM's now have a chance to "return" their DHCP leases during shutdown, which is helpful for CI stability.
P.S. I don't want to cherry-pick this change as I don't want to change the field in cluster-templates in a CAPV v1.8 patch release
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #