🌱 Bump golangci-lint to v1.54.1 #2230
Conversation
Signed-off-by: killianmuldoon <[email protected]>
k8s-ci-robot
added
size/XS
| @@ -23,5 +23,5 @@ jobs: | |||
| - name: golangci-lint | |||
| uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # tag=v3.6.0 | |||
| with: | |||
| version: v1.53.3 | |||
| version: v1.54.1 | |||
There was a problem hiding this comment.
@chrischdi do you want to include this is in the grouped CI cherry-picks? #2228
We might be able to auto cherry-pick it easily after that one merges across branches though
There was a problem hiding this comment.
I would avoid cherry-picking back golangci-lint bumps if not strictly necessary
(Just in general, because if we don't want to actively fix linter findings on release branches it doesn't make a lot of sense, except merge conflicts for other cherry-picks)
|
/lgtm |
|
Thx! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e46eb027d7645b9028d7672b64fe9d36e9623718
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Bump golangci-lint to v1.54.1.
The main feature here is go v1.21 support. Notes:
v1.54.0: golangci/[email protected] (release)
v1.54.1: golangci/[email protected] (release)