🌱 Don't require Validate session privileges to check if user session is active

[laozc]

What this PR does / why we need it:
Session active check does not work for Datacenter scoped TKG admin account.
API SessionIsActive requires ValidateSession permission which is not listed in current doc.
It can be replaced with a simple Datacenter retrieval call to do the same thing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2066

[k8s-ci-robot]

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/ok-to-test

[chrischdi]

/lgtm

@srm09 or @randomvariable , would be awesome to get your take on this.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: eea4888bf2744c5cd234a0a7a0a6d38232b8e438

[randomvariable]

Had to read the govmomi code for UserSession to understand what happened. It makes sense, but maybe worth leaving a comment that UserSession(blah) actually does a managed object retrieval for future devs.

[sbueringer]

@laozc

API SessionIsActive requires ValidateSession permission which is not listed in current doc.

I think this is not correct:

Session

• Message
• Validate session
  https://docs.vmware.com/en/VMware-Tanzu-Kubernetes-Grid/1.6/vmware-tanzu-kubernetes-grid-16/GUID-mgmt-clusters-vsphere.html#vsphere-permissions

If I got it correctly it is just that Validate Session is required on the root (?). And using UserSession (aka getting currentSession) requires less permissions.

I'm fine in general with the change, but is there any vCenter documentation confirming that UserSession / currentSession requires no specific pemissions? (@laozc @randomvariable)

[randomvariable]

I don't know if there's something confirming that permissions are not required, but permissions are described here https://docs.vmware.com/en/VMware-vSphere/8.0/vsphere-security/GUID-ED56F3C4-77D0-49E3-88B6-B99B8B437B62.html

Similar to what we do with CloudTrail in CAPA, at some point may want to enable the privilege recorder https://docs.vmware.com/en/VMware-vSphere/8.0/vsphere-security/GUID-8A5066BB-BE0C-48AD-9DDB-F3446AD3B9F6.html and capture the output, though that might be restricted in VMC.

[sbueringer]

Thx for the info. That could become very useful going forward

[sbueringer]

Renamed the PR as it's clearly documented that a TKG admin requires session validation privileges. Nonetheless, makes sense to reduce the required privileges

[sbueringer]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a0d09581253b94e95388b3774ea64d3aa148f805

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment