Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 github: add edited and reopened as triggers for the GH workflow approval #2268

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Adds the types edited and reopened to the triggers for the PR approve GH Workflows action.

Before this PR the golangci-lint action could have been triggered by the edited or reopened actions.
The approval workflow would not get triggered in that case and did not approve the linter.

Cross-repo cherry-pick of kubernetes-sigs/cluster-api#9259

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we wait to confirm the fix works on CAPI first? or are we confident this works as expected?

@chrischdi
Copy link
Member Author

should we wait to confirm the fix works on CAPI first? or are we confident this works as expected?

I verified that it works.

The important point is to have the same triggers as the linter action to not hit the same case.

And they are now the same except:

  • Not having opened --> because there will be no ok-to-test label set
  • Adding labeled --> because we want to trigger the approval by this

@killianmuldoon
Copy link
Contributor

/lgtm

It makes sense to me - the existing action pretty much works except for not being triggered on updates.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash:

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1dd8cd9 into kubernetes-sigs:main Aug 21, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 21, 2023
killianmuldoon pushed a commit to killianmuldoon/cluster-api-provider-vsphere that referenced this pull request Aug 21, 2023
…flow-approval

🌱 github: add edited and reopened as triggers for the GH workflow approval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants