Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 LDFLAGS defined once for Makefile #2312

Merged
merged 2 commits into from
Sep 12, 2023
Merged

🌱 LDFLAGS defined once for Makefile #2312

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dceb4be
LDFLAGS defined once for Makefile
adityabhatia Aug 31, 2023
57c366c
add LDFLAGS comment to e2e docs
adityabhatia Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ ifeq ($(SELINUX_ENABLED),1)
endif

# Set build time variables including version details
LDFLAGS := $(shell hack/version.sh)
LDFLAGS ?= $(shell hack/version.sh)

# Additional CAPV vars (everything else is ~ kept in sync with core CAPI)
# Allow overriding manifest generation destination directory
Expand Down
1 change: 1 addition & 0 deletions hack/e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ export WORKLOAD_CONTROL_PLANE_ENDPOINT_IP
echo "Acquired Workload Cluster Control Plane IP: $WORKLOAD_CONTROL_PLANE_ENDPOINT_IP"

# save the docker image locally
export LDFLAGS=""
chrischdi marked this conversation as resolved.
Show resolved Hide resolved
make e2e-image
mkdir -p "$ARTIFACTS"/tempContainers
docker save gcr.io/k8s-staging-cluster-api/capv-manager:e2e -o "$DOCKER_IMAGE_TAR"
Expand Down
Loading