Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use higher concurrency for e2e tests #2340

Closed
wants to merge 1 commit into from

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sbueringer. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 9, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@31b8129). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2340   +/-   ##
=======================================
  Coverage        ?   50.20%           
=======================================
  Files           ?       87           
  Lines           ?     8041           
  Branches        ?        0           
=======================================
  Hits            ?     4037           
  Misses          ?     3677           
  Partials        ?      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-e2e-main-oldpreset 32f5d44 link true /test pull-cluster-api-provider-vsphere-e2e-main-oldpreset
pull-cluster-api-provider-vsphere-e2e-full-main 32f5d44 link true /test pull-cluster-api-provider-vsphere-e2e-full-main
pull-cluster-api-provider-vsphere-e2e-main 32f5d44 link true /test pull-cluster-api-provider-vsphere-e2e-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member

Note: we currently always use a single up for the kube-apiserver of a cluster. Increasing concurrency in tests leads to duplicate usage of IPS and breaks the tests

@sbueringer
Copy link
Member Author

Note: we currently always use a single up for the kube-apiserver of a cluster. Increasing concurrency in tests leads to duplicate usage of IPS and breaks the tests

Thx!

I opened an issue (#2342). Can you please check if it makes sense based on what you know?

@sbueringer
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants