-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Including all packages in coverage #2350
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
===========================================
+ Coverage 50.35% 60.40% +10.05%
===========================================
Files 87 164 +77
Lines 8041 9439 +1398
===========================================
+ Hits 4049 5702 +1653
+ Misses 3668 3322 -346
- Partials 324 415 +91 ☔ View full report in Codecov by Sentry. |
Interesting that this increases our coverage :D I would have expected the reverse Details: https://app.codecov.io/gh/kubernetes-sigs/cluster-api-provider-vsphere/pull/2350/indirect-changes I guess it is because we have packages without unit tests that are covered by unit tests of other packages |
It looks like we're doing quite good with just one line change. |
Thank you! Yup looks a lot better than expected already /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 92501bcddde10c02bdfcdc5a6a8302cfa429dac6
|
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #