Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Including all packages in coverage #2350

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

laozc
Copy link
Member

@laozc laozc commented Sep 12, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +10.05% 🎉

Comparison is base (c154905) 50.35% compared to head (d619a5f) 60.40%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2350       +/-   ##
===========================================
+ Coverage   50.35%   60.40%   +10.05%     
===========================================
  Files          87      164       +77     
  Lines        8041     9439     +1398     
===========================================
+ Hits         4049     5702     +1653     
+ Misses       3668     3322      -346     
- Partials      324      415       +91     

see 110 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

sbueringer commented Sep 12, 2023

Interesting that this increases our coverage :D I would have expected the reverse

Details: https://app.codecov.io/gh/kubernetes-sigs/cluster-api-provider-vsphere/pull/2350/indirect-changes

I guess it is because we have packages without unit tests that are covered by unit tests of other packages

@laozc
Copy link
Member Author

laozc commented Sep 13, 2023

It looks like we're doing quite good with just one line change.

@sbueringer
Copy link
Member

Thank you!

Yup looks a lot better than expected already

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92501bcddde10c02bdfcdc5a6a8302cfa429dac6

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 21665a2 into kubernetes-sigs:main Sep 13, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants