🌱 Get rid of unstructured type in VSphereVM reconciler

[zhanggbj]

What this PR does / why we need it:

I'm assuming this is an intermediate state when to support supervisor mode, so it uses unstructured type in VSphereVM reconciler to support two modes. As we now have vmoperator to reconcile VM in supervisor mode, I think we are good to get rid of unstructured type in VSphereVM reconciler, but better to have a review from folks who're more familiar with supervisor mode.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2056

[codecov]

Codecov Report

Patch coverage: 7.31% and project coverage change: +0.49% 🎉

Comparison is base (21665a2) 60.23% compared to head (c7d13ec) 60.73%.
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
+ Coverage   60.23%   60.73%   +0.49%     
==========================================
  Files         164      164              
  Lines        9439     9392      -47     
==========================================
+ Hits         5686     5704      +18     
+ Misses       3334     3277      -57     
+ Partials      419      411       -8     

Files Changed	Coverage Δ
pkg/services/vimmachine.go	61.40% <7.31%> (+9.61%)	⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sbueringer]

Really nice cleanup. One nit.

Let's ignore the non-ideal logs for now (that we already had before this PR), we'll improve that when we improve logging of the entire controller

[zhanggbj]

@sbueringer all comments are addressed, it's ready for a second look, thx!

[sbueringer]

Thx!

/lgtm

/hold
Just want to merge #2352 before

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ffeec6b3b13925d75d6a707ed6ab4c552a2c2bea

[sbueringer]

/hold cancel
Ah nope we should be good. No overlap

[sbueringer]

/test pull-cluster-api-provider-vsphere-e2e-full-main

[chrischdi]

Very nice cleanup

/approve

/hold pending CI

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Entirely up to you, but e2e-full automatically blocks merging as soon as it's triggered so we don't have to manage the hold manually (Just fyi)

[chrischdi]

Entirely up to you, but e2e-full automatically blocks merging as soon as it's triggered so we don't have to manage the hold manually (Just fyi)

Ah right, this was recently changed :-)

/hold cancel

[sbueringer]

Not really :D. We always had this in CAPV (since before we took over). We just changed it in core CAPI to be the same.

[killianmuldoon]

/retest