Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ refactor context for vspheredeploymentzone controller #2369

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

zhanggbj
Copy link
Contributor

What this PR does / why we need it:

Refactor context for vspheredeploymentzone_controller.go and vspheredeploymentzone_controller_domain.go, as they are related, also refactor some underlying functions. Please find more background in #2295

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2295

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2023
@zhanggbj zhanggbj mentioned this pull request Sep 20, 2023
18 tasks
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 57.89% and project coverage change: -0.16% ⚠️

Comparison is base (09ff688) 60.97% compared to head (b65a713) 60.81%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2369      +/-   ##
==========================================
- Coverage   60.97%   60.81%   -0.16%     
==========================================
  Files         164      164              
  Lines        9465     9464       -1     
==========================================
- Hits         5771     5756      -15     
- Misses       3284     3294      +10     
- Partials      410      414       +4     
Files Changed Coverage Δ
pkg/services/govmomi/cluster/service.go 78.57% <ø> (ø)
pkg/services/vimmachine.go 57.01% <7.31%> (ø)
...rollers/vspheredeploymentzone_controller_domain.go 50.73% <79.31%> (-8.09%) ⬇️
controllers/vspheredeploymentzone_controller.go 75.89% <86.66%> (-0.11%) ⬇️
pkg/services/govmomi/cluster/rule.go 58.06% <100.00%> (ø)
pkg/services/govmomi/cluster/vmgroup.go 85.00% <100.00%> (ø)
pkg/services/govmomi/metadata/metadata.go 75.51% <100.00%> (ø)
pkg/taggable/get.go 82.35% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhanggbj zhanggbj changed the title [WIP] ✨ refactor context for vspheredeploymentzone controller ✨ refactor context for vspheredeploymentzone controller Sep 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

@zhanggbj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main b65a713 link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

Thank you!!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ae182122a8ccac5274eadd1fe6ba29249facc210

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 425d5ed into kubernetes-sigs:main Sep 20, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 20, 2023
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ankitasw Ankitasw mentioned this pull request Sep 28, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants