-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ refactor context for vspheredeploymentzone controller #2369
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2369 +/- ##
==========================================
- Coverage 60.97% 60.81% -0.16%
==========================================
Files 164 164
Lines 9465 9464 -1
==========================================
- Hits 5771 5756 -15
- Misses 3284 3294 +10
- Partials 410 414 +4
☔ View full report in Codecov by Sentry. |
bdba1da
to
0400f79
Compare
Signed-off-by: Gong Zhang <[email protected]>
0400f79
to
b65a713
Compare
@zhanggbj: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thank you!! /lgtm |
LGTM label has been added. Git tree hash: ae182122a8ccac5274eadd1fe6ba29249facc210
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Refactor context for vspheredeploymentzone_controller.go and vspheredeploymentzone_controller_domain.go, as they are related, also refactor some underlying functions. Please find more background in #2295
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #2295