Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Refactor context for vspheremachine controller #2376

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

Ankitasw
Copy link
Member

What this PR does / why we need it:

Refactor context for vspheremachine_controller.go. Please find more background in #2295

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2295

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2023
@Ankitasw Ankitasw changed the title Refactor context for vspheremachine controller ✨ Refactor context for vspheremachine controller Sep 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: +0.20% 🎉

Comparison is base (eab5a45) 60.54% compared to head (7280671) 60.74%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
+ Coverage   60.54%   60.74%   +0.20%     
==========================================
  Files         164      164              
  Lines        9464     9469       +5     
==========================================
+ Hits         5730     5752      +22     
+ Misses       3313     3300      -13     
+ Partials      421      417       -4     
Files Changed Coverage Δ
controllers/vspheremachine_controller.go 76.55% <88.88%> (+0.43%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main 7280671 link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ankitasw Ankitasw mentioned this pull request Sep 21, 2023
12 tasks
@Ankitasw
Copy link
Member Author

Ankitasw commented Sep 21, 2023

cc @zhanggbj @chrischdi

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb89731cca6ef2fd9e93b823742bef848f4d6dcd

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@chrischdi chrischdi mentioned this pull request Sep 21, 2023
18 tasks
@k8s-ci-robot k8s-ci-robot merged commit 5b06095 into kubernetes-sigs:main Sep 21, 2023
13 of 14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 21, 2023
@Ankitasw Ankitasw deleted the refactor-ctx-vspherevm branch September 21, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants