🌱 Use number of esxi hosts as worker node count for anti-affinity e2e test

[chrischdi]

What this PR does / why we need it:

This PR removes the requirement to have at least 4 esxi hosts for the anti-affinity test. Instead it uses the number of available esxi hosts with a maximum of 10.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2368

[chrischdi]

/test help

[k8s-ci-robot]

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-vsphere-conformance-main
• /test pull-cluster-api-provider-vsphere-e2e-full-main
• /test pull-cluster-api-provider-vsphere-e2e-main
• /test pull-cluster-api-provider-vsphere-test-integration-main
• /test pull-cluster-api-provider-vsphere-test-main
• /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-vsphere-apidiff-main
• pull-cluster-api-provider-vsphere-e2e-main
• pull-cluster-api-provider-vsphere-test-integration-main
• pull-cluster-api-provider-vsphere-test-main
• pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chrischdi]

/test pull-cluster-api-provider-vsphere-e2e-full-main

[chrischdi]

/retitle 🌱 Use number of esxi hosts as worker node count for anti-affinity e2e test

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.13% ⚠️

Comparison is base (5b06095) 60.92% compared to head (486b612) 60.79%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2377      +/-   ##
==========================================
- Coverage   60.92%   60.79%   -0.13%     
==========================================
  Files         164      164              
  Lines        9469     9469              
==========================================
- Hits         5769     5757      -12     
- Misses       3288     3296       +8     
- Partials      412      416       +4     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrischdi]

Codecov Report

Patch coverage has no change and project coverage change: -0.13% ⚠️

Comparison is base (5b06095) 60.92% compared to head (486b612) 60.79%.

Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

Interesting that changes to a _test.go can decrease coverage.

[killianmuldoon]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: f9c669bbfa3e4383833425195183aa42ac1f950e

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[killianmuldoon]

Interesting that changes to a _test.go can decrease coverage.

I definitely got an increase from touching a Makefile the other day - it's not perfect, but hopefully it's useful 🤷

[killianmuldoon]

@chrischdi WDYT about backporting this one to 1.7 and 1.8? Seems like it will be part of the puzzle for failuredomain tests in future.

[chrischdi]

/cherry-pick release-1.8

[chrischdi]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@chrischdi: #2377 failed to apply on top of branch "release-1.8":

Applying: Use number of esxi hosts as worker node count for anti-affinity e2e test
Using index info to reconstruct a base tree...
M	test/e2e/anti_affinity_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/anti_affinity_test.go
CONFLICT (content): Merge conflict in test/e2e/anti_affinity_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use number of esxi hosts as worker node count for anti-affinity e2e test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@chrischdi: #2377 failed to apply on top of branch "release-1.7":

Applying: Use number of esxi hosts as worker node count for anti-affinity e2e test
Using index info to reconstruct a base tree...
M	test/e2e/anti_affinity_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/anti_affinity_test.go
CONFLICT (content): Merge conflict in test/e2e/anti_affinity_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use number of esxi hosts as worker node count for anti-affinity e2e test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

Sorry 😐

[chrischdi]

Will do manual cherry-picks tomorrow :-)

[chrischdi]

Yes

Wondering if this is spam. Joined 2 days ago and made this comment + a citation on the corresponding issue which does not make any sense.