-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump Cluster API to v1.5.2 #2401
🌱 Bump Cluster API to v1.5.2 #2401
Conversation
Signed-off-by: killianmuldoon <[email protected]>
/cherry-pick release-1.8 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not sure what our feeling is on backporting these updates to older branches. It looks like we definitely backported v1.5.1 to 1.8, but release 1.7 and older aren't on latest patch releases. I'm fine to keep that as the pattern for now, but maybe we should consider updating release-1.7 to CAPI v1.4.7? @chrischdi @fabriziopandini WDYT? |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
==========================================
+ Coverage 60.87% 60.88% +0.01%
==========================================
Files 164 164
Lines 9473 9473
==========================================
+ Hits 5767 5768 +1
+ Misses 3293 3292 -1
Partials 413 413 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d20bbfaa589bb0155b6ae11f4617c1068c3513ae
|
+1 to backporting:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@killianmuldoon: #2401 failed to apply on top of branch "release-1.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Will do the backports manually |
Bump Cluster API to its latest patch release.
Release notes here: https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.5.2