🐛 flatcar: Run kubeadm after containerd #2405
Conversation
Ensure kubeadm runs after containerd to avoid a race condition between the two. We intentionally add an After= directive and not a Requires= directive to avoid breaking things for distros which use Ignition and don't use containerd. See kubernetes-sigs/image-builder#939. Signed-off-by: Johanan Liebermann <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2405 +/- ##
==========================================
+ Coverage 60.70% 60.80% +0.09%
==========================================
Files 164 164
Lines 9473 9473
==========================================
+ Hits 5751 5760 +9
+ Misses 3304 3298 -6
+ Partials 418 415 -3 ☔ View full report in Codecov by Sentry. |
|
@johananl: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test help |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
|
/lgtm Thanks for the PR. This makes sense to me. Running the e2e-full tests to see if we hit any issue. This also includes ignition. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 38f14f209ce260a7f2175dcdd53969709e58b1bb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Ensure kubeadm runs after containerd to avoid a race condition between the two.
We intentionally add an
After=directive and not aRequires=directive to avoid breaking things for distros which use Ignition and don't use containerd.See kubernetes-sigs/image-builder#939.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):None