Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump kube-vip to 0.6.3 and enable service mode #2508

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

laozc
Copy link
Member

@laozc laozc commented Nov 15, 2023

What this PR does / why we need it:
Bump the kube-vip to 0.6.3 in the flavor templates.
Also enable kube-vip to watch service for LB.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2507

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2023
@laozc laozc changed the title Bump kube-vip to 0.6.3 with service mode enabled 🌱 Bump kube-vip to 0.6.3 with service mode enabled Nov 15, 2023
@sbueringer
Copy link
Member

Thx!

Sounds reasonable

/lgtm
/approve

(Prow will block for e2e automatically, btw I'm working with the VMC support to resolve a VMC environment issue)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a1f9002b043dedfb5ea930a309d9ba1778433b0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@sbueringer
Copy link
Member

/retest

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea2041d) 63.69% compared to head (eca7e5e) 63.75%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
+ Coverage   63.69%   63.75%   +0.05%     
==========================================
  Files         123      123              
  Lines        8746     8746              
==========================================
+ Hits         5571     5576       +5     
+ Misses       2761     2758       -3     
+ Partials      414      412       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer sbueringer changed the title 🌱 Bump kube-vip to 0.6.3 with service mode enabled 🌱 Bump kube-vip to 0.6.3 and enable service mode Nov 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8ba873f into kubernetes-sigs:main Nov 17, 2023
23 of 24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump kube-vip version in flavor templates
3 participants