Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Improve logging & error handling #2527

Merged
merged 1 commit into from
Dec 12, 2023

Improve logging and error handling

3f27366
Select commit
Loading
Failed to load commit list.
Merged

✨ Improve logging & error handling #2527

Improve logging and error handling
3f27366
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2023 in 0s

63.45% (-0.28%) compared to 89f4029

View this Pull Request on Codecov

63.45% (-0.28%) compared to 89f4029

Details

Codecov Report

Attention: 400 lines in your changes are missing coverage. Please review.

Comparison is base (89f4029) 63.73% compared to head (3f27366) 63.45%.
Report is 10 commits behind head on main.

Files Patch % Lines
pkg/services/govmomi/util.go 16.94% 49 Missing ⚠️
pkg/services/govmomi/service.go 11.32% 47 Missing ⚠️
controllers/vspherecluster_reconciler.go 27.08% 33 Missing and 2 partials ⚠️
controllers/serviceaccount_controller.go 58.97% 27 Missing and 5 partials ⚠️
controllers/vspheremachine_controller.go 69.79% 26 Missing and 3 partials ⚠️
controllers/vspherevm_controller.go 52.08% 20 Missing and 3 partials ⚠️
controllers/servicediscovery_controller.go 75.64% 19 Missing ⚠️
pkg/session/session.go 56.41% 17 Missing ⚠️
pkg/util/machines.go 0.00% 15 Missing ⚠️
controllers/vspheredeploymentzone_controller.go 65.85% 14 Missing ⚠️
... and 21 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2527      +/-   ##
==========================================
- Coverage   63.73%   63.45%   -0.28%     
==========================================
  Files         123      120       -3     
  Lines        8812     8685     -127     
==========================================
- Hits         5616     5511     -105     
+ Misses       2773     2747      -26     
- Partials      423      427       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov