Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add e2e test coverage for namingStrategy #2550

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Dec 13, 2023

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2428

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf9483f) 63.58% compared to head (ca0ee65) 63.73%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2550      +/-   ##
==========================================
+ Coverage   63.58%   63.73%   +0.14%     
==========================================
  Files         120      120              
  Lines        8685     8685              
==========================================
+ Hits         5522     5535      +13     
+ Misses       2735     2726       -9     
+ Partials      428      424       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@chrischdi
Copy link
Member

Did hit a panic failure. Fixing via: #2552

/retest

@sbueringer
Copy link
Member Author

Thx for fixing the panic. e2e-full seems green now. Should we merge this PR or do you want to rerun tests? (I"m in no rush, just asking :))

@chrischdi
Copy link
Member

Fine with merging

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2e6817e2c960277e579554b345235ca4b2fa1337

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2888456 into kubernetes-sigs:main Dec 14, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Dec 14, 2023
@sbueringer sbueringer deleted the pr-naming-strategy branch December 14, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CAPI's namingStrategy in end-to-end testing
3 participants