-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add e2e test coverage for namingStrategy #2550
🌱 Add e2e test coverage for namingStrategy #2550
Conversation
Signed-off-by: Stefan Büringer [email protected]
/test pull-cluster-api-provider-vsphere-e2e-full-main |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2550 +/- ##
==========================================
+ Coverage 63.58% 63.73% +0.14%
==========================================
Files 120 120
Lines 8685 8685
==========================================
+ Hits 5522 5535 +13
+ Misses 2735 2726 -9
+ Partials 428 424 -4 ☔ View full report in Codecov by Sentry. |
/test pull-cluster-api-provider-vsphere-e2e-full-main |
Did hit a panic failure. Fixing via: #2552 /retest |
Thx for fixing the panic. e2e-full seems green now. Should we merge this PR or do you want to rerun tests? (I"m in no rush, just asking :)) |
Fine with merging /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 2e6817e2c960277e579554b345235ca4b2fa1337
|
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2428