Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add k8s v1.29.0 ova's #2561

Merged
merged 1 commit into from
Dec 22, 2023
Merged

✨ Add k8s v1.29.0 ova's #2561

merged 1 commit into from
Dec 22, 2023

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Dec 19, 2023 •
edited by sbueringer
Loading

What this PR does / why we need it:

Introduces kubernetes v1.29.0 ova's.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2564

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2023
@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-full-main
  • /test pull-cluster-api-provider-vsphere-e2e-main
  • /test pull-cluster-api-provider-vsphere-test-integration-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-main
  • pull-cluster-api-provider-vsphere-test-integration-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@chrischdi chrischdi changed the title Add k8s v1.29.0 ova's ✨ Add k8s v1.29.0 ova's Dec 19, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8bb2e3) 64.67% compared to head (cf3245e) 64.38%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2561      +/-   ##
==========================================
- Coverage   64.67%   64.38%   -0.30%     
==========================================
  Files         118      118              
  Lines        8539     8580      +41     
==========================================
+ Hits         5523     5524       +1     
- Misses       2595     2625      +30     
- Partials      421      431      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi chrischdi force-pushed the pr-bump-k8s-1-29 branch 2 times, most recently from b19c348 to 458a6d9 Compare December 19, 2023 17:08
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@chrischdi
Copy link
Member Author

Uploaded fresh OVA's, the other ones were broken with some containerd issues.

/retest

@chrischdi chrischdi changed the title ✨ Add k8s v1.29.0 ova's ✨ [WIP] Add k8s v1.29.0 ova's Dec 19, 2023
@sbueringer sbueringer mentioned this pull request Dec 20, 2023
Closed
2 tasks
@sbueringer
Copy link
Member

PR looks good so far. I created a corresponding issue and one in CPI to track the work

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@chrischdi chrischdi force-pushed the pr-bump-k8s-1-29 branch 3 times, most recently from ee0ea6f to 68dd33a Compare December 21, 2023 09:45
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 21, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

1 similar comment
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@chrischdi chrischdi changed the title ✨ [WIP] Add k8s v1.29.0 ova's ✨ Add k8s v1.29.0 ova's Dec 21, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

Did pick the wrong version for clusterctl upgrade tests, because CAPV v1.8 (because of the templates) does/do not support v1.29 due to the kube-vip issues)

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-test-main

flake

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@chrischdi
Copy link
Member Author

e2e-full is very flaky (also on main / periodics :-( )

/test pull-cluster-api-provider-vsphere-e2e-full-main

https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-vsphere#periodic-e2e-full-main

fabriziopandini
fabriziopandini reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good!
looking forward to see the issue to be fixed in kube-vip!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c3ce4ce1cdc6d30039ebd10c91b8854c36c9d16

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79d3ac0 into kubernetes-sigs:main Dec 22, 2023
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Dec 22, 2023
@sbueringer
Copy link
Member

@chrischdi Should we cherry-pick this PR and the follow-up fix PR to release-1.8?

@chrischdi chrischdi mentioned this pull request Jan 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @k8s-ci-robot @sbueringer @fabriziopandini