-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add vcsim server provider #2613
✨ Add vcsim server provider #2613
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
==========================================
- Coverage 64.94% 64.19% -0.75%
==========================================
Files 118 118
Lines 8580 8620 +40
==========================================
- Hits 5572 5534 -38
- Misses 2582 2647 +65
- Partials 426 439 +13 ☔ View full report in Codecov by Sentry. |
/hold |
@fabriziopandini IIRC you wanted to make some further changes before review, correct? |
237988b
to
4c70529
Compare
/hold cancel |
@sbueringer this one should be ready for review now |
/retest |
/test pull-cluster-api-provider-vsphere-e2e-main (to run all tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed my mind and added comments instead of opening a PR (A large percentag of my points are questions)
/retest |
test/infrastructure/tmp/api/v1alpha1/etcdcluster_annotations.go
Outdated
Show resolved
Hide resolved
Last one from my side |
3f2ed60
to
8245cd0
Compare
Thank you very much. Really nice work :) /lgtm |
LGTM label has been added. Git tree hash: 384539b0d244b9575d0abb922aacac95a290d605
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds a vcsim server that can be used in tilt for:
The second option also provides some of the building blocks for implementing E2E for CAPV in supervisor mode on VMC (or on any vSphere), but some work is still necessary to make this possible