🌱 flavor-gen: bump CPI manifests and use embed instead of hardcoding #2625
Conversation
|
/test help |
k8s-ci-robot
added
the
cncf-cla: yes
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XXL
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2625 +/- ##
==========================================
- Coverage 64.72% 64.56% -0.16%
==========================================
Files 118 118
Lines 8580 8580
==========================================
- Hits 5553 5540 -13
- Misses 2596 2605 +9
- Partials 431 435 +4 ☔ View full report in Codecov by Sentry. |
chrischdi
force-pushed
the
pr-flavorgen-cpi-from-helm
branch
2 times, most recently
from
95bf556
to
aaad7d1
Compare
|
/test pull-cluster-api-provider-vsphere-test-main |
|
/overwrite pull-cluster-api-provider-vsphere-apidiff-main |
|
/retest |
chrischdi
changed the title
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
chrischdi
force-pushed
the
pr-flavorgen-cpi-from-helm
branch
from
aaad7d1
to
6e40efb
Compare
|
Thx! /approve /assign @zhanggbj @laozc @fabriziopandini |
k8s-ci-robot
added
the
approved
|
Ah, looks like the linter isn't happy yet |
chrischdi
force-pushed
the
pr-flavorgen-cpi-from-helm
branch
from
6e40efb
to
1ea3723
Compare
|
/test pull-cluster-api-provider-vsphere-e2e-full-main |
|
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e6bd515bcf0cfeeede64fd90341baeb5c4c4aef2
|
What this PR does / why we need it:
Use
helm template --namespace=kube-systemto generate the CPI manifests used in flavor-gen.This allows to streamline the update progress of CPI.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #