-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update docs to link to the OVAs in the community-owned GCS bucket #2641
Conversation
Signed-off-by: Stefan Büringer [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 9def7aa073a2faa8812dccf2e3363db579ffe475
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
- Coverage 64.76% 64.69% -0.07%
==========================================
Files 118 118
Lines 8580 8580
==========================================
- Hits 5557 5551 -6
- Misses 2593 2597 +4
- Partials 430 432 +2 ☔ View full report in Codecov by Sentry. |
@sbueringer I found two other instances of https://storage.googleapis.com/ might be worth checking them as well |
Thx. I'll take a look. CI fortunately doesn't download the images. We upload the images to the CI environment when we upload them to GCS. (so they are just available in vCenter) |
FYI, all GCS buckets |
Thx. I wasn't aware of that. I think we'll move then once the communication is out. We are also storing some other files in these buckets in CAPV & CAPI (mostly "deployment YAMLs") |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #