Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update docs to link to the OVAs in the community-owned GCS bucket #2641

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2024
@sbueringer sbueringer changed the title 🌱 Update docs to link to the OVAs in the community-owned GCP bucket 🌱 Update docs to link to the OVAs in the community-owned GCS bucket Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 18, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9def7aa073a2faa8812dccf2e3363db579ffe475

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83722c3) 64.76% compared to head (51ffac4) 64.69%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
- Coverage   64.76%   64.69%   -0.07%     
==========================================
  Files         118      118              
  Lines        8580     8580              
==========================================
- Hits         5557     5551       -6     
- Misses       2593     2597       +4     
- Partials      430      432       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziopandini
Copy link
Member

@sbueringer I found two other instances of https://storage.googleapis.com/ might be worth checking them as well
Also, should we do something to use new ova from our CI (also old branches)

@k8s-ci-robot k8s-ci-robot merged commit 89e749e into kubernetes-sigs:main Jan 18, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jan 18, 2024
@sbueringer
Copy link
Member Author

@sbueringer I found two other instances of https://storage.googleapis.com/ might be worth checking them as well Also, should we do something to use new ova from our CI (also old branches)

Thx. I'll take a look.

CI fortunately doesn't download the images. We upload the images to the CI environment when we upload them to GCS. (so they are just available in vCenter)

@sbueringer sbueringer deleted the pr-move-ovas branch January 18, 2024 15:12
@ameukam
Copy link
Member

ameukam commented Jan 18, 2024

FYI, all GCS buckets artifacts.*.appspot.com will go away ultimately. There is no ETA for this. We will have a communication about this.
Those are related to GCR and we want to migrate to Google Artifact Registry.

@sbueringer
Copy link
Member Author

sbueringer commented Jan 18, 2024

Thx. I wasn't aware of that. I think we'll move then once the communication is out. We are also storing some other files in these buckets in CAPV & CAPI (mostly "deployment YAMLs")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants