🌱 hack: add capv-janitor for automated ci cleanup #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2681 +/- ##
==========================================
+ Coverage 64.49% 64.68% +0.19%
==========================================
Files 119 119
Lines 8640 8640
==========================================
+ Hits 5572 5589 +17
+ Misses 2633 2621 -12
+ Partials 435 430 -5 ☔ View full report in Codecov by Sentry. |
chrischdi
force-pushed
the
pr-introduce-ci-janitor
branch
4 times, most recently
from
261d643
to
75f922b
Compare
|
/retest (flake) |
k8s-ci-robot
added
the
needs-rebase
chrischdi
force-pushed
the
pr-introduce-ci-janitor
branch
from
75f922b
to
2cbfb68
Compare
k8s-ci-robot
removed
the
needs-rebase
|
I'll take a look next week |
sbueringer
reviewed
Feb 5, 2024
|
Main comment is this one: #2681 (comment) (potentially a lot follows from that) |
k8s-ci-robot
added
size/L
chrischdi
force-pushed
the
pr-introduce-ci-janitor
branch
3 times, most recently
from
4b2c353
to
dfca622
Compare
chrischdi
force-pushed
the
pr-introduce-ci-janitor
branch
from
dfca622
to
d393aca
Compare
sbueringer
reviewed
Feb 5, 2024
chrischdi
force-pushed
the
pr-introduce-ci-janitor
branch
from
38625a6
to
db154f6
Compare
chrischdi
force-pushed
the
pr-introduce-ci-janitor
branch
from
db154f6
to
2f9794b
Compare
k8s-ci-robot
added
size/XL
|
/lgtm /hold Not sure if you want further reviews. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1231d9b9be95628c71325e35491ebf33eb726886
|
|
/approve |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
hack/tools/janitor, a small tool which can be run as cronjob in CI to cleanup leftover objects over time.As of now cleanup was done manually but since running jobs in parallel, we may have more leftover objects so its more often required to cleanup things.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #