Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ go.mod: Bump capi to main commit 4061a478b1610b308207da434e4eb4fc7af55de7n #2766

Merged
merged 1 commit into from
Feb 29, 2024
Merged

✨ go.mod: Bump capi to main commit 4061a478b1610b308207da434e4eb4fc7af55de7n #2766

merged 1 commit into from
Feb 29, 2024

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

  • Bumps sigs.k8s.io/cluster-api to commit 0f47a19e038ee6b0d3b1e7675a62cdaf84face8c to prepare for CAPI v1.7 release
  • Removes test/infrastructure/tmp-to-be-deleted and use CAPI's package for inmemory instead

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2024
@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-main
  • /test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main
  • /test pull-cluster-api-provider-vsphere-test-integration-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-blocking-main
  • pull-cluster-api-provider-vsphere-test-integration-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 26, 2024
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.99%. Comparing base (c4d4781) to head (7685215).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2766      +/-   ##
==========================================
- Coverage   64.07%   63.99%   -0.09%     
==========================================
  Files         160      160              
  Lines        9345     9345              
==========================================
- Hits         5988     5980       -8     
- Misses       2902     2906       +4     
- Partials      455      459       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrischdi chrischdi force-pushed the pr-capi-main-1-7 branch 2 times, most recently from f3c2614 to c33f2e5 Compare February 26, 2024 12:48
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main

@chrischdi
Copy link
Member Author

/tide merge-method-squash

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2024
@chrischdi chrischdi force-pushed the pr-capi-main-1-7 branch 2 times, most recently from 8f3b118 to 1810ac3 Compare February 27, 2024 07:23
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@chrischdi chrischdi changed the title ✨ go.mod: Bump capi to main commit 0f47a19e038ee6b0d3b1e7675a62cdaf84face8c ✨ go.mod: Bump capi to main commit 4061a478b1610b308207da434e4eb4fc7af55de7n Feb 29, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-ci-latest-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-conformance-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-upgrade-1-29-1-30-main

fabriziopandini
fabriziopandini reviewed Feb 29, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for driving this change!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2f65a1879762be14e3fdf6b43c424d098c5d6bda

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7b9f705 into kubernetes-sigs:main Feb 29, 2024
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@srm09 srm09 Awaiting requested review from srm09

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@chrischdi @k8s-ci-robot @fabriziopandini