🌱 github: still create a draft release on release notes generation failures #2878
Conversation
k8s-ci-robot
added
cncf-cla: yes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
+ Coverage 64.14% 64.17% +0.03%
==========================================
Files 160 160
Lines 9367 9367
==========================================
+ Hits 6008 6011 +3
+ Misses 2903 2901 -2
+ Partials 456 455 -1 ☔ View full report in Codecov by Sentry. |
| run: | | ||
| make generate-release-notes | ||
| make generate-release-notes || echo "Failed to generate release notes" >> _releasenotes/${{ env.RELEASE_TAG }}.md |
There was a problem hiding this comment.
I assume this redirects only the echo into the file? (nothing from the make target)
There was a problem hiding this comment.
oh well, let me check this, good point!
There was a problem hiding this comment.
Yes, only redirects stdout from the echo!
There was a problem hiding this comment.
❯ (echo "hello" && fail) || echo "failed" >> out.txt
hello
zsh: command not found: fail
❯ cat out.txt
failed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2b9ef2b268432610bee590bbc95fe83e605da928
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Changes the github action which creates a draft release to not fail when generating release-notes failed.
Instead it will create the draft release with a note that the release-notes were not successfully generated.
This allows us to still manually generate the release notes and publish the release.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #