🌱 Use vm operator v1.8.6 for supervisor e2e testing #2894
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
size/XXL
fabriziopandini
force-pushed
the
vm-operator-v1.8.6
branch
from
b682fb3
to
410d95c
Compare
|
/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main |
|
/test |
|
@fabriziopandini: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main |
fabriziopandini
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
test/infrastructure/net-operator/controllers/networkinterface_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/vcsim/api/v1alpha1/vmoperatordependencies_types.go
Outdated
Show resolved
Hide resolved
.golangci.yml
Outdated
| @@ -188,6 +188,8 @@ issues: | |||
| # We are disabling default golangci exclusions because we want to help reviewers to focus on reviewing the most relevant | |||
There was a problem hiding this comment.
Did we intentionally not bump dependencies in go.mod files? Or am I missing something
There was a problem hiding this comment.
Bumping dependencies embedded in the code is unrelated to what we use for testing
There was a problem hiding this comment.
Yes and no. We use the API types from our dependencies to deploy stuff like VirtualMachine etc.
But if we're sure it's not a problem we can do this in a follow-up (but I think we should follow-up).
I mostly got confused because the VirtualMachineImage was cluster scoped in v1.8.5 and then I started looking. But I think this also didn't change with v1.8.6..
IIRC CR code that is checking if a resource is namespaced or not is using rest mapping to do this. So this shouldn't depend on the types we use anyway. tl;dr. I guess all good
There was a problem hiding this comment.
In v1.8.6 there's v1alpha2 and things changed.
Before there was a cluster-scoped and non-cluster-scoped VirtualMachineImage.
Now there is a cluster-scoped ClusterVirtualMachineImage if I got it right, and the non-cluster-scoped VirtualMachineImage.
There was a problem hiding this comment.
Let's just do a follow-up to bump go dependencies as well before v1.10.0
test/infrastructure/net-operator/external/net-operator/api/v1alpha1/doc.go
Outdated
Show resolved
Hide resolved
test/infrastructure/net-operator/external/net-operator/api/v1alpha1/doc.go
Outdated
Show resolved
Hide resolved
|
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main |
|
Requires a |
|
/test ? |
|
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c3127879195258c64672e0a3f32bb9a184baf911
|
|
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main |
|
/cherry-pick release-1.10 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
removed
the
lgtm
|
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main |
sbueringer
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 23933563a6d72c7a051b3df5a9f6b6530d13dd87
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #2913 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2883