Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump the all-go-mod-patch-and-minor group across 2 directories with 7 updates #3012

Closed
wants to merge 1 commit into from
Closed

🌱 Bump the all-go-mod-patch-and-minor group across 2 directories with 7 updates #3012

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 20, 2024 •
edited
Loading

Bumps the all-go-mod-patch-and-minor group with 3 updates in the / directory: k8s.io/api, k8s.io/apiextensions-apiserver and k8s.io/cluster-bootstrap.
Bumps the all-go-mod-patch-and-minor group with 4 updates in the /test directory: k8s.io/api, k8s.io/apiextensions-apiserver, k8s.io/cluster-bootstrap and sigs.k8s.io/kind.

Updates k8s.io/api from 0.29.4 to 0.29.5

Commits

Updates k8s.io/apiextensions-apiserver from 0.29.4 to 0.29.5

Commits

Updates k8s.io/apimachinery from 0.29.4 to 0.29.5

Commits

Updates k8s.io/client-go from 0.29.4 to 0.29.5

Commits

Updates k8s.io/cluster-bootstrap from 0.29.4 to 0.29.5

Commits

Updates k8s.io/component-base from 0.29.4 to 0.29.5

Commits

Updates k8s.io/api from 0.29.4 to 0.29.5

Commits

Updates k8s.io/apiextensions-apiserver from 0.29.4 to 0.29.5

Commits

Updates k8s.io/apimachinery from 0.29.4 to 0.29.5

Commits

Updates k8s.io/client-go from 0.29.4 to 0.29.5

Commits

Updates k8s.io/cluster-bootstrap from 0.29.4 to 0.29.5

Commits

Updates k8s.io/component-base from 0.29.4 to 0.29.5

Commits

Updates sigs.k8s.io/kind from 0.22.0 to 0.23.0

Release notes

Sourced from sigs.k8s.io/kind's releases.

v0.23.0

This release introduces initial limited support for nerdctl and kube-proxy nftables mode.

  • The default node image is now Kubernetes 1.30.0: kindest/node:v1.30.0@sha256:047357ac0cfea04663786a612ba1eaba9702bef25227a794b52890dd8bcd692e
  • ipFamily config field is now validated
    • While technically a breaking change, if the value you set here is now caught as invalid it was being silently ignored and creating an ipv4 cluster previously and you should correct your config
  • Go 1.17+ is required for go install sigs.k8s.io/kind / building the kind binary
    • Prebuilt binaries are available as an alternative to go install
    • For local development make will automatically setup the correct go version
    • Note that the go team only supports 1.21+ and major linux distros have 1.19+
    • Future releases may increase this to a more current Go release
    • Future release may adopt toolchain in go.mod to make this seamless if you have go 1.21+ installed even without our makefile. We highly recommend installing go 1.21+

Images pre-built for this release:

  • v1.30.0: kindest/node:v1.30.0@sha256:047357ac0cfea04663786a612ba1eaba9702bef25227a794b52890dd8bcd692e
  • v1.29.4: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8
  • v1.28.9: kindest/node:v1.28.9@sha256:dca54bc6a6079dd34699d53d7d4ffa2e853e46a20cd12d619a09207e35300bd0
  • v1.27.13: kindest/node:v1.27.13@sha256:17439fa5b32290e3ead39ead1250dca1d822d94a10d26f1981756cd51b24b9d8
  • v1.26.15: kindest/node:v1.26.15@sha256:84333e26cae1d70361bb7339efb568df1871419f2019c80f9a12b7e2d485fe19
  • v1.25.16: kindest/node:v1.25.16@sha256:5da57dfc290ac3599e775e63b8b6c49c0c85d3fec771cd7d55b45fae14b38d3b

NOTE: You must use the @sha256 digest to guarantee an image built for this release, until such a time as we switch to a different tagging scheme. Even then we will highly encourage digest pinning for security and reproducibility reasons.

See also:

NOTE: These node images support amd64 and arm64, both of our supported platforms. You must use the same platform as your host, for more context see kubernetes-sigs/kind#2718

  • Correctly case kubeProxyMode: "none"

... (truncated)

Commits
  • 0296c52 version v0.23.0
  • 4a36b22 Merge pull request #3608 from BenTheElder/bump-kindnetd-mod
  • 96a3352 bump node image to 1.30.0
  • 1c8c510 bump base image
  • 7e41de9 bump local-path-provisioner image
  • 54682a2 bump kindnetd image
  • cd2ac64 bump kindnetd to k8s 0.29 (not 0.30 as we'd need go 1.22+, see runc issue 4233)
  • b9bba13 Merge pull request #3607 from BenTheElder/bump-go
  • 274e9d4 upgrade to go1.21.10
  • 6967c95 Merge pull request #3605 from kubernetes-sigs/dependabot/github_actions/actio...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot
---
a557a7f 
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/cluster-bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/cluster-bootstrap
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: sigs.k8s.io/kind
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-go-mod-patch-and-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 20, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2024
sbueringer
sbueringer reviewed May 21, 2024
View reviewed changes
test/go.mod
k8s.io/klog/v2 v2.110.1
k8s.io/utils v0.0.0-20231127182322-b307cd553661
sigs.k8s.io/cluster-api v0.0.0-00010101000000-000000000000
sigs.k8s.io/cluster-api-provider-vsphere v0.0.0-00010101000000-000000000000
sigs.k8s.io/cluster-api/test v0.0.0-00010101000000-000000000000
sigs.k8s.io/controller-runtime v0.17.5
sigs.k8s.io/kind v0.22.0
sigs.k8s.io/kind v0.23.0
Copy link
Member

@sbueringer sbueringer May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this one is okay in CAPV. We don't really depend on the kind version. But we can consider adding this to the ignore list in the dependabot config as well.

Might be cleaner to ignore it here as well and bump with CAPI to avoid strange issues going forward (in case there is actually an issue that affects the bootstrap cluster in e2e tests)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrischdi WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, we can also remove the direct dependency by copying over this single function:

https://github.com/kubernetes-sigs/kind/blob/main/pkg/errors/concurrent.go#L42 + using kerrors in there instead.

I could add this to #3010

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that, sounds good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We'll rebase this PR after yours merged, then)

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 082e60215db8a2840896cdf2bba1f6cdbdf065c5

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 21, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this May 21, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/all-go-mod-patch-and-minor-1c302e2080 branch May 21, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@sbueringer sbueringer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k8s-ci-robot @sbueringer @chrischdi