✨ vGPU implementation #3025

birksl · 2024-05-24T12:26:03Z

Builds on the changes in #2272

What this PR does / why we need it:
Support adding vGPUs to VMs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1972

linux-foundation-easycla · 2024-05-24T12:26:07Z

The committers listed above are authorized under a signed CLA.

✅ login: birksl / name: Birk Lewin (9fc17c9, 27933fa, b85ad40, cd250d7, 47d7d72, 8a6a558, 1e9a6e1, c7f4781, cea0016, 0e84953, 1353b4d, 9f16da1, ee5d3ac, 438c6e5, 6e8d105, 1f433eb, f18ba35, a6c0fd8, 609542b)
✅ login: puneetkatyal / name: Puneet Katyal (0091291, c5d2a78)

k8s-ci-robot · 2024-05-24T12:26:12Z

Welcome @birksl!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-05-24T12:26:12Z

Hi @birksl. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

birksl · 2024-05-24T12:35:11Z

/easycla

Makefile

docs/gpu-vgpu.md

pkg/services/govmomi/vcenter/clone.go

apis/v1beta1/types.go

test/e2e/config/vsphere-dev.yaml

test/e2e/data/infrastructure-vsphere-govmomi/main/vgpu/kustomization.yaml

chrischdi

One major question: https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/3025/files#r1617231776

apis/v1beta1/types.go

test/e2e/config/vsphere-dev.yaml

test/e2e/config/vsphere.yaml

chrischdi · 2024-05-31T08:32:15Z

/ok-to-test

birksl · 2024-05-31T13:28:42Z

/retest

internal/webhooks/vspheremachinetemplate.go

pkg/services/govmomi/pci/device.go

internal/webhooks/vspheremachine_test.go

internal/webhooks/vspheremachine.go

docs/gpu-vgpu.md

chrischdi

Sorry for the long round-trip between reviews.

Another round of nits then I think this is good!

cc @neolit123 maybe this is interesting for you.

Co-authored-by: Christian Schlotter <[email protected]>

birksl · 2024-06-20T07:55:52Z

Thanks for the guidance. I learnt a lot :)

apis/v1beta1/types.go

docs/gpu-vgpu.md

internal/webhooks/vspheremachine.go

internal/webhooks/vspheremachine_test.go

pkg/services/govmomi/vcenter/clone.go

pkg/services/govmomi/pci/device.go

Co-authored-by: Lubomir I. Ivanov <[email protected]>

neolit123 · 2024-06-20T10:28:31Z

don't forget to squash all commits before the final merge.

birksl · 2024-06-20T11:02:43Z

/retest

lubronzhan

lgtm

sbueringer · 2024-06-21T06:45:03Z

don't forget to squash all commits before the final merge.

Not needed. We can just use tide to squash (we improved our release notes tool a while ago, so it can handle squash commits now)

neolit123 · 2024-06-21T07:01:18Z

don't forget to squash all commits before the final merge.

Not needed. We can just use tide to squash (we improved our release notes tool a while ago, so it can handle squash commits now)

probably the blow scenario will never happen, but note that squash nukes gpg signatures, so some contributor might decide to create a problem.

chrischdi · 2024-06-21T09:52:30Z

/lgtm

Thanks @neolit123 for also taking a look!

k8s-ci-robot · 2024-06-21T09:52:35Z

LGTM label has been added.

Git tree hash: 431e3c4e236991e0ecf51615460596202a7aeb32

sbueringer · 2024-07-10T07:46:56Z

apis/v1beta1/types.go

@@ -251,13 +251,24 @@ type PCIDeviceSpec struct {
 	// DeviceID is the device ID of a virtual machine's PCI, in integer.
 	// Defaults to the eponymous property value in the template from which the
 	// virtual machine is cloned.
+	// Mutually exclusive with VGPUProfile as VGPUProfile and DeviceID + VendorID
+	// are two independent ways to define PCI devices.
 	// +kubebuilder:validation:Required


Suggested change

// +kubebuilder:validation:Required

// +optional

Same for VendorID & VGPUProfile

(Note: this won't change the CRD YAML as "omitempty" already made the fields optional in the generated YAML)

sbueringer · 2024-07-10T07:54:14Z

docs/gpu-vgpu.md

+$ make dev-flavors
+go run ./packaging/flavorgen --output-dir /home/user/.cluster-api/overrides/infrastructure-vsphere/v0.0.0


Suggested change

$ make dev-flavors

go run ./packaging/flavorgen --output-dir /home/user/.cluster-api/overrides/infrastructure-vsphere/v0.0.0

$ make release-flavors

We dropped the dev-flavors target in the meantime

sbueringer · 2024-07-10T07:54:35Z

docs/gpu-vgpu.md

+go run ./packaging/flavorgen --output-dir /home/user/.cluster-api/overrides/infrastructure-vsphere/v0.0.0
+```
+
+Edit the generated Cluster template (`cluster-template.yaml`) to set the values for the `pciDevices` array. Here we are editing the VSphereMachineTemplate object for the worker nodes. This will create a worker node with a single NVIDIA 16GB vGPU device attached to the VM.


Suggested change

Edit the generated Cluster template (`cluster-template.yaml`) to set the values for the `pciDevices` array. Here we are editing the VSphereMachineTemplate object for the worker nodes. This will create a worker node with a single NVIDIA 16GB vGPU device attached to the VM.

Edit the generated Cluster template (e.g. `out/cluster-template.yaml`) to set the values for the `pciDevices` array. Here we are editing the VSphereMachineTemplate object for the worker nodes. This will create a worker node with a single NVIDIA 16GB vGPU device attached to the VM.

sbueringer · 2024-07-10T08:03:32Z

@birksl Thank you very much!

Sorry for the delay. I'll create a PR (#3101) to fix my findings. I don't want to delay merging this PR further.

/lgtm
/approve

k8s-ci-robot · 2024-07-10T08:03:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 24, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 24, 2024

k8s-ci-robot requested review from laozc and MaxRink May 24, 2024 12:26

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 24, 2024