Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump to CAPI main (v1.8.0 pre alpha) #3033

Merged
merged 8 commits into from
Jun 11, 2024
Merged

🌱 Bump to CAPI main (v1.8.0 pre alpha) #3033

merged 8 commits into from
Jun 11, 2024

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Jun 4, 2024 •
edited
Loading

What this PR does / why we need it:
Bump to CAPI main (v1.8.0 pre alpha) to unblock work on new E2E tests for #2995

It also includes

  • bump to go 1.22.3
  • bump to controller gen v0.15.0 and conversion gen v0.30.0

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 4, 2024
@fabriziopandini
Copy link
Member Author

/test

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-main
  • /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
  • pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main

@fabriziopandini
Copy link
Member Author

/retest

1 similar comment
@fabriziopandini
Copy link
Member Author

/retest

@fabriziopandini fabriziopandini force-pushed the bump-capi-main branch 2 times, most recently from 3f61b54 to 4a9c6d4 Compare June 5, 2024 09:33
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 5, 2024
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 5, 2024
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

2 similar comments
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

@fabriziopandini
Copy link
Member Author

/hold
while I'm triaging test failures

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main

1 similar comment
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

sbueringer
sbueringer reviewed Jun 10, 2024
View reviewed changes
go.mod Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
test/e2e/ownerrefs_finalizers_test.go Show resolved Hide resolved
test/e2e/ownerrefs_finalizers_test.go Outdated Show resolved Hide resolved
test/e2e/ownerrefs_finalizers_test.go Outdated Show resolved Hide resolved
test/e2e/ownerrefs_finalizers_test.go Show resolved Hide resolved
test/e2e/ownerrefs_finalizers_test.go Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini mentioned this pull request Jun 11, 2024
Merged
@chrischdi
Copy link
Member

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main

Testing if CI is still ok

chrischdi
chrischdi reviewed Jun 11, 2024
View reviewed changes
hack/ensure-go.sh Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main d6fcc88 link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

chrischdi
chrischdi reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19fc84fcb222c1e5b0fb5ad838464d85983e84da

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@sbueringer
Copy link
Member

/lgtm

@fabriziopandini
Copy link
Member Author

PR in test infra merged
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit f237a0f into kubernetes-sigs:main Jun 11, 2024
14 of 15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jun 11, 2024
@fabriziopandini fabriziopandini mentioned this pull request Jun 11, 2024
Closed
16 tasks
@fabriziopandini fabriziopandini deleted the bump-capi-main branch June 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @k8s-ci-robot @chrischdi @sbueringer